KickJava   Java API By Example, From Geeks To Geeks.

Java > Open Source Codes > org > hammurapi > inspectors > UseEqualsInsteadOfCompareToInspector


1 /*
2   * Hammurapi
3  * Automated Java code review system.
4  * Copyright (C) 2004 Hammurapi Group
5  *
6  * This program is free software; you can redistribute it and/or modify
7  * it under the terms of the GNU General Public License as published by
8  * the Free Software Foundation; either version 2 of the License, or
9  * (at your option) any later version.
10  *
11  * This program is distributed in the hope that it will be useful,
12  * but WITHOUT ANY WARRANTY; without even the implied warranty of
13  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
14  * GNU General Public License for more details.
15  *
16  * You should have received a copy of the GNU General Public License
17  * along with this program; if not, write to the Free Software
18  * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA
19  *
20  * URL: http://www.hammurapi.org
21  * e-Mail: support@hammurapi.biz
22   */

23 package org.hammurapi.inspectors;
24
25 import org.hammurapi.InspectorBase;
26
27 import com.pavelvlasov.jsel.LanguageElement;
28 import com.pavelvlasov.jsel.expressions.Dot;
29 import com.pavelvlasov.jsel.expressions.Equal;
30 import com.pavelvlasov.jsel.expressions.Expression;
31 import com.pavelvlasov.jsel.expressions.IntegerConstant;
32 import com.pavelvlasov.jsel.expressions.MethodCall;
33 import com.pavelvlasov.jsel.expressions.PrimaryExpression;
34
35 /**
36  * @author Pavel Vlasov
37  *
38  * @version $Revision: 1.4 $
39  */

40 public class UseEqualsInsteadOfCompareToInspector extends InspectorBase {
41     
42     public void visit(MethodCall methodCall) {
43         PrimaryExpression name = methodCall.getName();
44         if (name instanceof Dot) {
45             name=(PrimaryExpression) name.getOperand(1);
46         }
47         
48         if ("compareTo".equals(name.toString()) && methodCall.getParameters().size()==1) {
49             LanguageElement parent = ((LanguageElement) methodCall).getParent();
50             if (parent instanceof Equal) {
51                 Object JavaDoc theOtherOperand=((Expression) parent).getOperand(0);
52                 if (theOtherOperand==methodCall) {
53                     theOtherOperand=((Expression) parent).getOperand(1);
54                 }
55                 
56                 if (theOtherOperand instanceof IntegerConstant
57                         && ((IntegerConstant) theOtherOperand).getValue()==0) {
58                     context.reportViolation(parent);
59                 }
60             }
61         }
62     }
63 }
64
Popular Tags