KickJava   Java API By Example, From Geeks To Geeks.

Java > Open Source Codes > org > hammurapi > inspectors > ThisReferenceAsArgumentInEjbRule


1 /*
2  * Hammurapi
3  * Automated Java code review system.
4  * Copyright (C) 2004 Hammurapi Group
5  *
6  * This program is free software; you can redistribute it and/or modify
7  * it under the terms of the GNU General Public License as published by
8  * the Free Software Foundation; either version 2 of the License, or
9  * (at your option) any later version.
10  *
11  * This program is distributed in the hope that it will be useful,
12  * but WITHOUT ANY WARRANTY; without even the implied warranty of
13  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
14  * GNU General Public License for more details.
15  *
16  * You should have received a copy of the GNU General Public License
17  * along with this program; if not, write to the Free Software
18  * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA
19  *
20  * URL: http://www.hammurapi.org
21  * e-Mail: support@hammurapi.biz
22  */
23 package org.hammurapi.inspectors;
24
25 import org.hammurapi.InspectorBase;
26
27 import com.pavelvlasov.jsel.JselException;
28 import com.pavelvlasov.jsel.LanguageElement;
29 import com.pavelvlasov.jsel.Repository;
30 import com.pavelvlasov.jsel.expressions.MethodCall;
31 import com.pavelvlasov.jsel.expressions.This;
32
33
34 /**
35  * ER-083
36  * Avoid passing the "this" reference as an argument
37  * @author Janos Czako
38  * @version $Revision: 1.2 $
39  */
40 public class ThisReferenceAsArgumentInEjbRule extends InspectorBase {
41     
42     /**
43      * The full qualified name of the class javax.ejb.EnterpriseBean.
44      */
45     private static final String JavaDoc EB_CLASS_NAME = "javax.ejb.EnterpriseBean";
46
47     /**
48      * Visits the methodcalls if they has this as parameter.
49      *
50      * @param element the methodcall to be reviewed.
51      */
52     public void visit(MethodCall element) {
53         LanguageElement lelement = ((LanguageElement) element);
54         Repository repository = lelement.getCompilationUnit().getPackage().getRepository();
55
56         try {
57             if (((LanguageElement) element).getEnclosingType().isKindOf(EB_CLASS_NAME)) {
58                 java.util.Iterator JavaDoc iter = element.getParameters().iterator();
59                 while (iter.hasNext()) {
60                     if (iter.next() instanceof This) {
61                         context.reportViolation(lelement);
62                     }
63                 }
64              }
65         } catch (JselException e) {
66             context.warn(lelement, e);
67         }
68     }
69     
70 }
71
Popular Tags