KickJava   Java API By Example, From Geeks To Geeks.

Java > Open Source Codes > org > hammurapi > inspectors > TextLabelsInSwitchStatementRule


1 /*
2  * Hammurapi
3  * Automated Java code review system.
4  * Copyright (C) 2004 Hammurapi Group
5  *
6  * This program is free software; you can redistribute it and/or modify
7  * it under the terms of the GNU General Public License as published by
8  * the Free Software Foundation; either version 2 of the License, or
9  * (at your option) any later version.
10  *
11  * This program is distributed in the hope that it will be useful,
12  * but WITHOUT ANY WARRANTY; without even the implied warranty of
13  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
14  * GNU General Public License for more details.
15  *
16  * You should have received a copy of the GNU General Public License
17  * along with this program; if not, write to the Free Software
18  * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA
19  *
20  * URL: http://www.hammurapi.org
21  * e-Mail: support@hammurapi.biz
22  */
23 package org.hammurapi.inspectors;
24
25 import org.hammurapi.InspectorBase;
26
27 import com.pavelvlasov.jsel.JselException;
28 import com.pavelvlasov.jsel.LanguageElement;
29 import com.pavelvlasov.jsel.TypeSpecification;
30 import com.pavelvlasov.jsel.VariableDefinition;
31 import com.pavelvlasov.jsel.expressions.Ident;
32 import com.pavelvlasov.jsel.expressions.StringConstant;
33 import com.pavelvlasov.jsel.statements.CasesGroup;
34
35
36 /**
37  * ER-101
38  * Avoid using text labels in "switch" statements
39  * @author Janos Czako
40  * @version $Revision: 1.2 $
41  */
42 public class TextLabelsInSwitchStatementRule extends InspectorBase {
43     
44     /**
45      * Type name for String.
46      */
47     private static final String JavaDoc STRING_TYPE = "java.lang.String";
48         
49     /**
50      * Reviews the cases of the switch statements, if they have String labels.
51      *
52      * @param element the case to be reviewed.
53      */
54     public void visit(CasesGroup element) {
55         java.util.Iterator JavaDoc iter = element.getCases().iterator();
56         while (iter.hasNext()) {
57             LanguageElement le = (LanguageElement) iter.next();
58             if (le instanceof StringConstant) {
59                 context.reportViolation(le);
60     }
61             else if (le instanceof Ident) {
62                 try {
63                     Object JavaDoc r =
64                         le.getEnclosingScope().getVariableNamespace().
65                             find(((Ident) le).getText()).getTypeName();
66                     if (r instanceof VariableDefinition) {
67                         VariableDefinition vd=(VariableDefinition) r;
68                         TypeSpecification typeSpecification = vd.getTypeSpecification();
69                             
70                         if (STRING_TYPE.equals(typeSpecification.getName())) {
71                             context.reportViolation(le);
72                         }
73                     }
74                 } catch (JselException e) {
75                     context.warn(element, e);
76                 }
77             }
78         }
79     }
80 }
81
Popular Tags