KickJava   Java API By Example, From Geeks To Geeks.

Java > Open Source Codes > org > hammurapi > inspectors > StaticCollectionsRule


1 /*
2  * Hammurapi
3  * Automated Java code review system.
4  * Copyright (C) 2004 Hammurapi Group
5  *
6  * This program is free software; you can redistribute it and/or modify
7  * it under the terms of the GNU General Public License as published by
8  * the Free Software Foundation; either version 2 of the License, or
9  * (at your option) any later version.
10  *
11  * This program is distributed in the hope that it will be useful,
12  * but WITHOUT ANY WARRANTY; without even the implied warranty of
13  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
14  * GNU General Public License for more details.
15  *
16  * You should have received a copy of the GNU General Public License
17  * along with this program; if not, write to the Free Software
18  * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA
19  *
20  * URL: http://www.hammurapi.org
21  * e-Mail: support@hammurapi.biz
22  */

23 package org.hammurapi.inspectors;
24
25 import org.hammurapi.InspectorBase;
26
27 import com.pavelvlasov.jsel.Field;
28 import com.pavelvlasov.jsel.JselException;
29 import com.pavelvlasov.jsel.VariableDefinition;
30
31
32 /**
33  * ER-087
34  * Avoid "static" collections; they can grow without bounds
35  * @author Janos Czako
36  * @version $Revision: 1.2 $
37  */

38 public class StaticCollectionsRule extends InspectorBase {
39     
40     /**
41      * static Collection attribute is a violation
42      */

43     private static final String JavaDoc STATIC = "static";
44     
45     /**
46      * Reviews the type definition, if it has static Collection attributes.
47      *
48      * @param type the type definition to be reviewed.
49      */

50     public void visit(com.pavelvlasov.jsel.Class clazz) {
51         java.util.Iterator JavaDoc iter = clazz.getFields().iterator();
52         
53         while (iter.hasNext()) {
54             Field field = (Field) iter.next();
55             if (field instanceof VariableDefinition && field.getModifiers().contains(STATIC)) {
56                 VariableDefinition vd = (VariableDefinition) field;
57                 try {
58                     if (vd.getTypeSpecification().getType().isKindOf("java.util.Collection")) {
59                         context.reportViolation(field);
60                     }
61                 } catch (JselException e) {
62                     context.warn(field, e);
63                 }
64             }
65         }
66     }
67 }
68
Popular Tags