KickJava   Java API By Example, From Geeks To Geeks.

Java > Open Source Codes > org > hammurapi > inspectors > ReturnThisFromEjbRule


1 /*
2  * Hammurapi
3  * Automated Java code review system.
4  * Copyright (C) 2004 Hammurapi Group
5  *
6  * This program is free software; you can redistribute it and/or modify
7  * it under the terms of the GNU General Public License as published by
8  * the Free Software Foundation; either version 2 of the License, or
9  * (at your option) any later version.
10  *
11  * This program is distributed in the hope that it will be useful,
12  * but WITHOUT ANY WARRANTY; without even the implied warranty of
13  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
14  * GNU General Public License for more details.
15  *
16  * You should have received a copy of the GNU General Public License
17  * along with this program; if not, write to the Free Software
18  * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA
19  *
20  * URL: http://www.hammurapi.org
21  * e-Mail: support@hammurapi.biz
22  */
23 package org.hammurapi.inspectors;
24
25 import org.hammurapi.InspectorBase;
26
27 import com.pavelvlasov.jsel.JselException;
28 import com.pavelvlasov.jsel.Method;
29 import com.pavelvlasov.jsel.TypeBody;
30 import com.pavelvlasov.jsel.expressions.This;
31 import com.pavelvlasov.jsel.statements.ReturnStatement;
32 import com.pavelvlasov.review.SourceMarker;
33 import com.pavelvlasov.util.Visitor;
34
35
36 /**
37  * ER-084
38  * Avoid returning "this" from public methods.
39  * @author Janos Czako
40  * @version $Revision: 1.3 $
41  */
42 public class ReturnThisFromEjbRule extends InspectorBase {
43     
44     public void visit(Method method) {
45         if (method.getModifiers().contains("public")) {
46             TypeBody tb = method.getEnclosingType();
47             try {
48                 if (tb.isKindOf("javax.ejb.EnterpriseBean")) {
49                     method.accept(new Visitor() {
50                         public boolean visit(Object JavaDoc target) {
51                             if (target instanceof ReturnStatement) {
52                                 ReturnStatement returnStatement=(ReturnStatement) target;
53                                 if (returnStatement.getExpression() instanceof This) {
54                                     context.reportViolation((SourceMarker) returnStatement);
55                                 }
56                             }
57                             return true;
58                         }
59                     });
60                 }
61             } catch (JselException e) {
62                 context.warn(method, e);
63             }
64         }
65     }
66 }
67
Popular Tags