KickJava   Java API By Example, From Geeks To Geeks.

Java > Open Source Codes > org > hammurapi > inspectors > PublicStaticArrayFieldsRule


1 /*
2  * Hammurapi
3  * Automated Java code review system.
4  * Copyright (C) 2004 Hammurapi Group
5  *
6  * This program is free software; you can redistribute it and/or modify
7  * it under the terms of the GNU General Public License as published by
8  * the Free Software Foundation; either version 2 of the License, or
9  * (at your option) any later version.
10  *
11  * This program is distributed in the hope that it will be useful,
12  * but WITHOUT ANY WARRANTY; without even the implied warranty of
13  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
14  * GNU General Public License for more details.
15  *
16  * You should have received a copy of the GNU General Public License
17  * along with this program; if not, write to the Free Software
18  * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA
19  *
20  * URL: http://www.hammurapi.org
21  * e-Mail: support@hammurapi.biz
22  */

23 package org.hammurapi.inspectors;
24
25 import java.util.Collections JavaDoc;
26 import java.util.HashSet JavaDoc;
27 import java.util.Set JavaDoc;
28
29 import org.hammurapi.InspectorBase;
30
31 import com.pavelvlasov.jsel.VariableDefinition;
32
33
34 /**
35  * ER-091
36  * Avoid using "public static final" array fields
37  * @author Janos Czako
38  * @version $Revision: 1.2 $
39  */

40 public class PublicStaticArrayFieldsRule extends InspectorBase {
41     
42     private static final Set JavaDoc modifiers;
43     
44     static {
45         HashSet JavaDoc mf=new HashSet JavaDoc();
46         mf.add("public");
47         mf.add("static");
48         mf.add("final");
49         modifiers=Collections.unmodifiableSet(mf);
50     }
51     
52     /**
53      * Reviews the type definitions, if they have public static final
54      * array attributes.
55      *
56      * @param element the type to be reviewed.
57      */

58     public void visit(VariableDefinition element) {
59         if (element.getModifiers().containsAll(modifiers) && element.getTypeSpecification().getDimensions()>0) {
60             context.reportViolation(element);
61         }
62     }
63     
64 }
65
Popular Tags