KickJava   Java API By Example, From Geeks To Geeks.

Java > Open Source Codes > org > hammurapi > inspectors > OperationParameterNamesRule


1 /*
2  * Hammurapi
3  * Automated Java code review system.
4  * Copyright (C) 2004 Hammurapi Group
5  *
6  * This program is free software; you can redistribute it and/or modify
7  * it under the terms of the GNU General Public License as published by
8  * the Free Software Foundation; either version 2 of the License, or
9  * (at your option) any later version.
10  *
11  * This program is distributed in the hope that it will be useful,
12  * but WITHOUT ANY WARRANTY; without even the implied warranty of
13  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
14  * GNU General Public License for more details.
15  *
16  * You should have received a copy of the GNU General Public License
17  * along with this program; if not, write to the Free Software
18  * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA
19  *
20  * URL: http://www.hammurapi.org
21  * e-Mail: support@hammurapi.biz
22  */
23 package org.hammurapi.inspectors;
24
25 import org.hammurapi.InspectorBase;
26
27 import com.pavelvlasov.jsel.JselException;
28 import com.pavelvlasov.jsel.Method;
29 import com.pavelvlasov.jsel.Parameter;
30
31
32 /**
33  * ER-099
34  * Avoid using method parameter names that conflict with class member names
35  * @author Janos Czako
36  * @version $Revision: 1.2 $
37  */
38 public class OperationParameterNamesRule extends InspectorBase {
39     
40     /**
41      * Reviews the method definitions if they have parameters with the same
42      * name as one of the class attribute.
43      *
44      * @param element the method definition to be reviewed.
45      */
46     public void visit(Method element) {
47         java.util.Iterator JavaDoc parameters = element.getParameters().iterator();
48         
49         while (parameters.hasNext()) {
50             Parameter parameter = (Parameter) parameters.next();
51             String JavaDoc paramName = parameter.getName();
52             try {
53                 if (element.getEnclosingScope().getVariableNamespace().find(paramName)!=null) {
54                     context.reportViolation(parameter);
55                 }
56             } catch (JselException e) {
57                 context.warn(parameter, e);
58             }
59         }
60     }
61     
62 }
63
Popular Tags