KickJava   Java API By Example, From Geeks To Geeks.

Java > Open Source Codes > org > hammurapi > inspectors > NotifyRule


1 /*
2  * Hammurapi
3  * Automated Java code review system.
4  * Copyright (C) 2004 Hammurapi Group
5  *
6  * This program is free software; you can redistribute it and/or modify
7  * it under the terms of the GNU General Public License as published by
8  * the Free Software Foundation; either version 2 of the License, or
9  * (at your option) any later version.
10  *
11  * This program is distributed in the hope that it will be useful,
12  * but WITHOUT ANY WARRANTY; without even the implied warranty of
13  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
14  * GNU General Public License for more details.
15  *
16  * You should have received a copy of the GNU General Public License
17  * along with this program; if not, write to the Free Software
18  * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA
19  *
20  * URL: http://www.hammurapi.org
21  * e-Mail: support@hammurapi.biz
22  */
23 package org.hammurapi.inspectors;
24
25 import org.hammurapi.InspectorBase;
26
27 import com.pavelvlasov.jsel.expressions.MethodCall;
28 import com.pavelvlasov.review.SourceMarker;
29
30
31 /**
32  * ER-104
33  * Do not use 'notify ()'; use 'notifyAll ()' instead
34  * @author Pavel Vlasov
35  * @version $Revision: 1.2 $
36  */
37 public class NotifyRule extends InspectorBase {
38     
39     /**
40      * The name of the notify() method.
41      */
42     private static final String JavaDoc NOTIFY = "notify";
43     
44     /**
45      * Reviews the methodcalls, if they are notify() and so violate agains the
46      * rule.
47      *
48      * @param element the methodcall to be reviewed.
49      */
50     public void visit(MethodCall element) {
51         if (NOTIFY.compareTo(element.getName().toString())==0) {
52             if (element.getParameters().size()==0) {
53                 context.reportViolation((SourceMarker) element);
54             }
55         }
56     }
57     
58 }
59
Popular Tags