KickJava   Java API By Example, From Geeks To Geeks.

Java > Open Source Codes > org > hammurapi > inspectors > InvokeFinalizeRule


1 /*
2  * Hammurapi
3  * Automated Java code review system.
4  * Copyright (C) 2004 Hammurapi Group
5  *
6  * This program is free software; you can redistribute it and/or modify
7  * it under the terms of the GNU General Public License as published by
8  * the Free Software Foundation; either version 2 of the License, or
9  * (at your option) any later version.
10  *
11  * This program is distributed in the hope that it will be useful,
12  * but WITHOUT ANY WARRANTY; without even the implied warranty of
13  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
14  * GNU General Public License for more details.
15  *
16  * You should have received a copy of the GNU General Public License
17  * along with this program; if not, write to the Free Software
18  * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA
19  *
20  * URL: http://www.hammurapi.org
21  * e-Mail: support@hammurapi.biz
22  */
23 package org.hammurapi.inspectors;
24
25 import org.hammurapi.InspectorBase;
26
27 import com.pavelvlasov.jsel.Code;
28 import com.pavelvlasov.jsel.LanguageElement;
29 import com.pavelvlasov.jsel.Method;
30 import com.pavelvlasov.jsel.expressions.MethodCall;
31 import com.pavelvlasov.review.SourceMarker;
32
33
34 /**
35  * ER-086
36  * Avoid calling 'finalize ()' explicitly
37  * @author Janos Czako
38  * @version $Revision: 1.4 $
39  */
40 public class InvokeFinalizeRule extends InspectorBase {
41     
42     private static final String JavaDoc FINALIZE = "finalize(";
43     
44     public void visit(MethodCall element) {
45         String JavaDoc method = element.toString();
46         
47         if (FINALIZE.equals(method) || method.endsWith("."+FINALIZE)) {
48             if ("super.finalize(".equals(method)) {
49                 Code code = ((LanguageElement) element).getEnclosingCode();
50                 if (code instanceof Method && ((Method) code).getParameters().isEmpty() && "finalize".equals(((Method) code).getName())) {
51                     return;
52                 }
53             }
54             context.reportViolation((SourceMarker) element);
55         }
56     }
57     
58 }
59
Popular Tags