KickJava   Java API By Example, From Geeks To Geeks.

Java > Open Source Codes > org > hammurapi > inspectors > HardcodedLiteralsRule


1 /*
2  * Hammurapi
3  * Automated Java code review system.
4  * Copyright (C) 2004 Hammurapi Group
5  *
6  * This program is free software; you can redistribute it and/or modify
7  * it under the terms of the GNU General Public License as published by
8  * the Free Software Foundation; either version 2 of the License, or
9  * (at your option) any later version.
10  *
11  * This program is distributed in the hope that it will be useful,
12  * but WITHOUT ANY WARRANTY; without even the implied warranty of
13  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
14  * GNU General Public License for more details.
15  *
16  * You should have received a copy of the GNU General Public License
17  * along with this program; if not, write to the Free Software
18  * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA
19  *
20  * URL: http://www.hammurapi.org
21  * e-Mail: support@hammurapi.biz
22  */
23 package org.hammurapi.inspectors;
24
25 import org.hammurapi.InspectorBase;
26
27 import com.pavelvlasov.jsel.LanguageElement;
28 import com.pavelvlasov.jsel.VariableDefinition;
29
30
31 /**
32  * ER-010
33  * Avoid hardwired character literals.
34  * Usage of literals in static final fields is allowed.
35  * @author Pavel Vlasov
36  * @version $Revision: 1.3 $
37  */
38 public class HardcodedLiteralsRule extends InspectorBase {
39     
40     private VariableDefinition currentStaticFinalField;
41
42     public void visit(VariableDefinition vd) {
43         if (currentStaticFinalField==null && vd.getModifiers().contains("static") && vd.getModifiers().contains("final")) {
44             currentStaticFinalField = vd;
45         }
46     }
47     
48     public void leave(VariableDefinition vd) {
49         currentStaticFinalField=null;
50     }
51     
52     protected void analyze(LanguageElement element) {
53         if (currentStaticFinalField==null) {
54             context.reportViolation(element);
55         }
56     }
57 }
58
Popular Tags