KickJava   Java API By Example, From Geeks To Geeks.

Java > Open Source Codes > org > hammurapi > inspectors > FinalParametersRule


1 /*
2  * Hammurapi
3  * Automated Java code review system.
4  * Copyright (C) 2004 Hammurapi Group
5  *
6  * This program is free software; you can redistribute it and/or modify
7  * it under the terms of the GNU General Public License as published by
8  * the Free Software Foundation; either version 2 of the License, or
9  * (at your option) any later version.
10  *
11  * This program is distributed in the hope that it will be useful,
12  * but WITHOUT ANY WARRANTY; without even the implied warranty of
13  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
14  * GNU General Public License for more details.
15  *
16  * You should have received a copy of the GNU General Public License
17  * along with this program; if not, write to the Free Software
18  * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA
19  *
20  * URL: http://www.hammurapi.org
21  * e-Mail: support@hammurapi.biz
22  */
23 package org.hammurapi.inspectors;
24
25 import org.hammurapi.InspectorBase;
26
27 import com.pavelvlasov.jsel.Operation;
28 import com.pavelvlasov.jsel.Parameter;
29
30 /**
31  * For comprehensibility, formal parameters should be final.
32  * @author Pavel Vlasov
33  * @version $Revision: 1.2 $
34  */
35 public class FinalParametersRule extends InspectorBase {
36     
37     /**
38      * Reviews the method parameters.
39      *
40      * @param parameter the parameter to be reviewed.
41      */
42     public void visit(Parameter parameter) {
43         if (!parameter.isFinal() && parameter.getParent() instanceof Operation && !isEmpty(((Operation) parameter.getParent()).getCompoundStatement())) {
44             context.reportViolation(parameter);
45         }
46     }
47 }
48
Popular Tags