KickJava   Java API By Example, From Geeks To Geeks.

Java > Open Source Codes > org > hammurapi > inspectors > DoNotUseNewForStringsRule


1 /*
2  * Hammurapi
3  * Automated Java code review system.
4  * Copyright (C) 2004 Hammurapi Group
5  *
6  * This program is free software; you can redistribute it and/or modify
7  * it under the terms of the GNU General Public License as published by
8  * the Free Software Foundation; either version 2 of the License, or
9  * (at your option) any later version.
10  *
11  * This program is distributed in the hope that it will be useful,
12  * but WITHOUT ANY WARRANTY; without even the implied warranty of
13  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
14  * GNU General Public License for more details.
15  *
16  * You should have received a copy of the GNU General Public License
17  * along with this program; if not, write to the Free Software
18  * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA
19  *
20  * URL: http://www.hammurapi.org
21  * e-Mail: support@hammurapi.biz
22  */
23 package org.hammurapi.inspectors;
24
25 import org.hammurapi.InspectorBase;
26
27 import com.pavelvlasov.jsel.JselException;
28 import com.pavelvlasov.jsel.TypeSpecification;
29 import com.pavelvlasov.jsel.expressions.Expression;
30 import com.pavelvlasov.jsel.expressions.NewObject;
31 import com.pavelvlasov.review.SourceMarker;
32
33 /**
34  * Packages should be imported in alphabetical order
35  * @author Pavel Vlasov
36  * @version $Revision: 1.3 $
37  */
38 public class DoNotUseNewForStringsRule extends InspectorBase {
39     
40     public void visit(NewObject newObject) {
41         try {
42             if (newObject.getTypeSpecification().isKindOf("java.lang.String")) {
43                 if (newObject.getParameters().size()==0) {
44                     context.reportViolation((SourceMarker) newObject);
45                 } else if (newObject.getParameters().size()==1) {
46                     TypeSpecification pt=((Expression) newObject.getParameters().get(0)).getTypeSpecification();
47                     if (pt.isKindOf("java.lang.String") || pt.isKindOf("java.lang.StringBuffer")) {
48                         context.reportViolation((SourceMarker) newObject);
49                     }
50                 }
51             }
52         } catch (JselException e) {
53             context.warn((SourceMarker) newObject, e);
54         }
55     }
56 }
57
Popular Tags