KickJava   Java API By Example, From Geeks To Geeks.

Java > Open Source Codes > org > hammurapi > inspectors > ConditionalExpressionRule


1 /*
2  * Hammurapi
3  * Automated Java code review system.
4  * Copyright (C) 2004 Hammurapi Group
5  *
6  * This program is free software; you can redistribute it and/or modify
7  * it under the terms of the GNU General Public License as published by
8  * the Free Software Foundation; either version 2 of the License, or
9  * (at your option) any later version.
10  *
11  * This program is distributed in the hope that it will be useful,
12  * but WITHOUT ANY WARRANTY; without even the implied warranty of
13  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
14  * GNU General Public License for more details.
15  *
16  * You should have received a copy of the GNU General Public License
17  * along with this program; if not, write to the Free Software
18  * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA
19  *
20  * URL: http://www.hammurapi.org
21  * e-Mail: support@hammurapi.biz
22  */
23 package org.hammurapi.inspectors;
24
25 import java.util.Iterator JavaDoc;
26
27 import org.hammurapi.InspectorBase;
28
29 import com.pavelvlasov.jsel.expressions.ConditionalExpression;
30 import com.pavelvlasov.jsel.expressions.False;
31 import com.pavelvlasov.jsel.expressions.True;
32 import com.pavelvlasov.review.SourceMarker;
33
34 /**
35  * @author Pavel Vlasov
36  * @version $Revision: 1.2 $
37  */
38 public class ConditionalExpressionRule extends InspectorBase {
39     
40     public void visit(ConditionalExpression expression) {
41         boolean hasNonBooleanLiterals=false;
42         Iterator JavaDoc it=expression.getOperands().iterator();
43         
44         // Move to the second operand
45 if (it.hasNext()) {
46             it.next();
47         }
48         
49         while (it.hasNext()) {
50             Object JavaDoc operand=it.next();
51             if (operand instanceof True) {
52                 continue;
53             }
54             
55             if (operand instanceof False) {
56                 continue;
57             }
58             
59             hasNonBooleanLiterals=true;
60         }
61         
62         if (!hasNonBooleanLiterals) {
63             context.reportViolation((SourceMarker) expression);
64         }
65     }
66 }
67
Popular Tags