KickJava   Java API By Example, From Geeks To Geeks.

Java > Open Source Codes > org > hammurapi > inspectors > BraceRule


1 /*
2  * Hammurapi
3  * Automated Java code review system.
4  * Copyright (C) 2004 Hammurapi Group
5  *
6  * This program is free software; you can redistribute it and/or modify
7  * it under the terms of the GNU General Public License as published by
8  * the Free Software Foundation; either version 2 of the License, or
9  * (at your option) any later version.
10  *
11  * This program is distributed in the hope that it will be useful,
12  * but WITHOUT ANY WARRANTY; without even the implied warranty of
13  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
14  * GNU General Public License for more details.
15  *
16  * You should have received a copy of the GNU General Public License
17  * along with this program; if not, write to the Free Software
18  * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA
19  *
20  * URL: http://www.hammurapi.org
21  * e-Mail: support@hammurapi.biz
22  */
23 package org.hammurapi.inspectors;
24
25 import org.hammurapi.InspectorBase;
26
27 import com.pavelvlasov.jsel.statements.CompoundStatement;
28 import com.pavelvlasov.jsel.statements.DoStatement;
29 import com.pavelvlasov.jsel.statements.ForStatement;
30 import com.pavelvlasov.jsel.statements.IfStatement;
31 import com.pavelvlasov.jsel.statements.WhileStatement;
32 import com.pavelvlasov.review.SourceMarker;
33
34 /**
35  * Complex statements like do, while, for, if, else need a brace enclosed block.
36  * @author Pavel Vlasov
37  * @version $Revision: 1.2 $
38  */
39 public class BraceRule extends InspectorBase {
40         
41     /**
42      * Reviews the if statements.
43      *
44      * @param statement the if statement to be reviewed
45      */
46     public void visit(IfStatement statement) {
47         if (!(statement.getStatement() instanceof CompoundStatement)) {
48             context.reportViolation((SourceMarker) statement.getStatement());
49         }
50         
51         if (!(statement.getElseStatement() == null
52             || statement.getElseStatement() instanceof CompoundStatement
53             || statement.getElseStatement() instanceof IfStatement)) {
54             context.reportViolation((SourceMarker) statement.getElseStatement());
55         }
56     }
57     
58     /**
59      * Reviews the do loops.
60      *
61      * @param statement the do statement to be reviewed.
62      */
63     public void visit(DoStatement statement) {
64         if (!(statement.getStatement() instanceof CompoundStatement)) {
65             context.reportViolation((SourceMarker) statement.getStatement());
66         }
67     }
68
69     /**
70      * Reviews the for loops.
71      *
72      * @param statement the for statement to be reviewed.
73      */
74     public void visit(ForStatement statement) {
75         if (!(statement.getStatement() instanceof CompoundStatement)) {
76             context.reportViolation((SourceMarker) statement.getStatement());
77         }
78     }
79
80     /**
81      * Reviews the while loops.
82      *
83      * @param statement the while statement to be reviewed.
84      */
85     public void visit(WhileStatement statement) {
86         if (!(statement.getStatement() instanceof CompoundStatement)) {
87             context.reportViolation((SourceMarker) statement.getStatement());
88         }
89     }
90
91     
92 }
93
Popular Tags