KickJava   Java API By Example, From Geeks To Geeks.

Java > Open Source Codes > org > hammurapi > inspectors > BooleanEqualityRule


1 /*
2  * Hammurapi
3  * Automated Java code review system.
4  * Copyright (C) 2004 Hammurapi Group
5  *
6  * This program is free software; you can redistribute it and/or modify
7  * it under the terms of the GNU General Public License as published by
8  * the Free Software Foundation; either version 2 of the License, or
9  * (at your option) any later version.
10  *
11  * This program is distributed in the hope that it will be useful,
12  * but WITHOUT ANY WARRANTY; without even the implied warranty of
13  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
14  * GNU General Public License for more details.
15  *
16  * You should have received a copy of the GNU General Public License
17  * along with this program; if not, write to the Free Software
18  * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA
19  *
20  * URL: http://www.hammurapi.org
21  * e-Mail: support@hammurapi.biz
22  */
23 package org.hammurapi.inspectors;
24
25 import java.util.Iterator JavaDoc;
26
27 import org.hammurapi.InspectorBase;
28
29 import com.pavelvlasov.jsel.expressions.Equal;
30 import com.pavelvlasov.jsel.expressions.Expression;
31 import com.pavelvlasov.jsel.expressions.False;
32 import com.pavelvlasov.jsel.expressions.NotEqual;
33 import com.pavelvlasov.jsel.expressions.True;
34 import com.pavelvlasov.review.SourceMarker;
35
36
37 /**
38  * ER-046
39  * Avoid equality operations on 'true' and 'false' boolean literals.
40  * @author Pavel Vlasov
41  * @version $Revision: 1.2 $
42  */
43 public class BooleanEqualityRule extends InspectorBase {
44     
45     public void visit(Equal element) {
46         check(element);
47     }
48     
49     public void visit(NotEqual element) {
50         check(element);
51     }
52
53     /**
54      * @param element
55      */
56     private void check(Expression element) {
57         Iterator JavaDoc it=element.getOperands().iterator();
58         while (it.hasNext()) {
59             Object JavaDoc o = it.next();
60             if (o instanceof True || o instanceof False) {
61                 context.reportViolation((SourceMarker) o);
62             }
63         }
64     }
65 }
66
67
Popular Tags