KickJava   Java API By Example, From Geeks To Geeks.

Java > Open Source Codes > org > hammurapi > inspectors > ArrayDeclarationRule


1 /*
2  * Hammurapi
3  * Automated Java code review system.
4  * Copyright (C) 2004 Hammurapi Group
5  *
6  * This program is free software; you can redistribute it and/or modify
7  * it under the terms of the GNU General Public License as published by
8  * the Free Software Foundation; either version 2 of the License, or
9  * (at your option) any later version.
10  *
11  * This program is distributed in the hope that it will be useful,
12  * but WITHOUT ANY WARRANTY; without even the implied warranty of
13  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
14  * GNU General Public License for more details.
15  *
16  * You should have received a copy of the GNU General Public License
17  * along with this program; if not, write to the Free Software
18  * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA
19  *
20  * URL: http://www.hammurapi.org
21  * e-Mail: support@hammurapi.biz
22  */

23 package org.hammurapi.inspectors;
24
25 import org.hammurapi.InspectorBase;
26
27 import com.pavelvlasov.jsel.VariableDefinition;
28 import com.pavelvlasov.jsel.impl.AST;
29
30
31 /**
32  * ER-018
33  * Array declarators should be placed next to the type, not the variable name
34  * @author Pavel Vlasov
35  * @version $Revision: 1.4 $
36  */

37 public class ArrayDeclarationRule extends InspectorBase {
38     
39     /**
40      * @param element
41      */

42     public void visit(VariableDefinition element) {
43         AST arrayNode=null;
44         AST identNode=null;
45         
46         for (AST node=(AST) element.getAst().getFirstChild(); node!=null; node=(AST) node.getNextSibling()) {
47             String JavaDoc typeName=node.getTypeName();
48             if ("TYPE".equals(typeName)) {
49                 AST node2=(AST) node.getFirstChild();
50                 if (node2!=null && "ARRAY_DECLARATOR".equals(node2.getTypeName())) {
51                     arrayNode=node2;
52                 }
53             } else if ("IDENT".equals(typeName)) {
54                 identNode=node;
55                 break;
56             }
57         }
58         
59         if (arrayNode!=null && identNode!=null && identNode.getColumn()<arrayNode.getColumn()) {
60            context.reportViolation(element);
61         }
62     }
63 }
64
Popular Tags