KickJava   Java API By Example, From Geeks To Geeks.

Java > Open Source Codes > org > hammurapi > inspectors > AccessToStaticMembersRule


1 /*
2  * Hammurapi
3  * Automated Java code review system.
4  * Copyright (C) 2004 Hammurapi Group
5  *
6  * This program is free software; you can redistribute it and/or modify
7  * it under the terms of the GNU General Public License as published by
8  * the Free Software Foundation; either version 2 of the License, or
9  * (at your option) any later version.
10  *
11  * This program is distributed in the hope that it will be useful,
12  * but WITHOUT ANY WARRANTY; without even the implied warranty of
13  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
14  * GNU General Public License for more details.
15  *
16  * You should have received a copy of the GNU General Public License
17  * along with this program; if not, write to the Free Software
18  * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA
19  *
20  * URL: http://www.hammurapi.org
21  * e-Mail: support@hammurapi.biz
22  */
23 package org.hammurapi.inspectors;
24
25 import org.hammurapi.InspectorBase;
26
27 import com.pavelvlasov.jsel.JselException;
28 import com.pavelvlasov.jsel.Method;
29 import com.pavelvlasov.jsel.VariableDefinition;
30 import com.pavelvlasov.jsel.expressions.Dot;
31 import com.pavelvlasov.jsel.expressions.Ident;
32 import com.pavelvlasov.jsel.expressions.This;
33 import com.pavelvlasov.review.SourceMarker;
34
35
36 /**
37  * ER-088
38  * Avoid using an object to access "static" fields or methods
39  * @author Pavel Vlasov
40  * @version $Revision: 1.3 $
41  */
42 public class AccessToStaticMembersRule extends InspectorBase {
43
44     /**
45      * The modifier static
46      */
47     private static final String JavaDoc STATIC = "static";
48
49     /**
50      * Reviews if the two side of the dot violates against the rule.
51      * (non static on the left and static on the right.)
52      *
53      * @param dot the dot to be reviewed
54      */
55     public void visit(Dot dot) {
56         Object JavaDoc dot1 = dot.getOperand(1);
57         if (dot1 instanceof Ident) {
58             try {
59                 Object JavaDoc provider = ((Ident) dot1).getProvider();
60                 boolean isStatic = false;
61                 if (provider instanceof Method) {
62                     if (((Method) provider).getModifiers().contains(STATIC)) {
63                         isStatic = true;
64                     }
65                 } else if (provider instanceof VariableDefinition) {
66                     if (((VariableDefinition) provider).getModifiers().contains(STATIC)) {
67                         isStatic = true;
68                     }
69                 }
70     
71                 if (isStatic) {
72                     Object JavaDoc dot0 = dot.getOperand(0);
73                     Ident user = null;
74                     if (dot0 instanceof This) {
75                         context.reportViolation((SourceMarker)dot1);
76                     } else if (dot0 instanceof Ident) {
77                         user = (Ident) dot0;
78                     } else if (dot0 instanceof Dot) {
79                         user = (Ident) ((Dot)dot0).getOperand(1);
80                     }
81                     if (user!=null) {
82                         provider = user.getProvider();
83                         if (provider instanceof VariableDefinition) {
84                             if (!((VariableDefinition)provider).getModifiers().contains(STATIC)) {
85                                 context.reportViolation((SourceMarker)dot1);
86                             }
87                         }
88                     }
89                 }
90             } catch (JselException e) {
91                 context.warn((SourceMarker)dot, e);
92             }
93         }
94     }
95 }
96
Popular Tags