KickJava   Java API By Example, From Geeks To Geeks.

Java > Open Source Codes > org > hammurapi > inspectors > AbstractMethodFromConstructorRule


1 /*
2  * Hammurapi
3  * Automated Java code review system.
4  * Copyright (C) 2004 Hammurapi Group
5  *
6  * This program is free software; you can redistribute it and/or modify
7  * it under the terms of the GNU General Public License as published by
8  * the Free Software Foundation; either version 2 of the License, or
9  * (at your option) any later version.
10  *
11  * This program is distributed in the hope that it will be useful,
12  * but WITHOUT ANY WARRANTY; without even the implied warranty of
13  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
14  * GNU General Public License for more details.
15  *
16  * You should have received a copy of the GNU General Public License
17  * along with this program; if not, write to the Free Software
18  * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA
19  *
20  * URL: http://www.hammurapi.org
21  * e-Mail: support@hammurapi.biz
22  */
23 package org.hammurapi.inspectors;
24
25 import org.hammurapi.InspectorBase;
26
27 import com.pavelvlasov.jsel.Constructor;
28 import com.pavelvlasov.jsel.JselException;
29 import com.pavelvlasov.jsel.LanguageElement;
30 import com.pavelvlasov.jsel.Method;
31 import com.pavelvlasov.jsel.OperationInfo;
32 import com.pavelvlasov.jsel.expressions.MethodCall;
33 import com.pavelvlasov.review.SourceMarker;
34 import com.pavelvlasov.util.Visitor;
35
36
37 /**
38  * ER-071
39  * Avoid calling an "abstract" method from a constructor in an "abstract" class
40  * @author Janos Czako
41  * @version $Revision: 1.3 $
42  */
43 public class AbstractMethodFromConstructorRule extends InspectorBase {
44
45     /**
46      * The abstract modifier.
47      */
48     private static final String JavaDoc ABSTRACT = "abstract";
49     
50     /**
51      * Reviews the constructor definitions if they violate against
52      * the rule;
53      *
54      * @param element the constructor definition.
55      */
56     public void visit(Constructor element) {
57         element.accept(new Visitor() {
58             public boolean visit(Object JavaDoc target) {
59                 if (target instanceof MethodCall) {
60                     MethodCall mc = (MethodCall) target;
61                     try {
62                         OperationInfo oi = mc.getProvider();
63                         if (oi==null) {
64                             context.warn((SourceMarker) mc, "Provider is null for "+mc+" at "+((LanguageElement) mc).getLocation());
65                         } else if (oi.getOperation() instanceof Method) {
66                             Method method = (Method) oi.getOperation();
67                             if (method.getModifiers().contains(ABSTRACT) && method.getEnclosingType()==((LanguageElement) mc).getEnclosingType()) {
68                                 context.reportViolation((SourceMarker) mc);
69                             }
70                         }
71                     } catch (JselException e) {
72                         context.warn((SourceMarker) mc, e);
73                     }
74                 }
75                 return true;
76             }
77         });
78     }
79 }
80
Popular Tags